Adding changes to GpiiActivity.java class and AndroidManifest.xml from Gpii Android Application in order to allow its own installation by Diegohp · Pull Request #27 · GPII/android

Diegohp · 2015-06-26T08:39:21Z

No description provided.

…ading GpiiActivity Android application in order to autodeploy it

javihernandez · 2015-06-30T17:49:31Z

platform/app/src/net/gpii/app/GpiiActivity.java

Every message needs to be in english

javihernandez · 2015-06-30T18:03:28Z

Beside my comments,

This branch is completely out of date and it needs to be updated with the current master
We do not use tabs for intents. Please, use 4-space intents

javihernandez · 2015-06-30T19:06:36Z

platform/app/src/net/gpii/app/GpiiActivity.java

s/Cloud4all/GPII

…I Android version

javihernandez · 2015-07-07T11:05:44Z

platform/app/src/net/gpii/app/GpiiActivity.java

Respect the headers

javihernandez · 2015-07-08T15:09:50Z

platform/app/src/net/gpii/app/GpiiActivity.java

empty whitespaces

javihernandez · 2015-07-08T15:14:33Z

@Diegohp,
thanks for keep working on this. Although you addressed some of my comments I still see a lot of extra whitespaces, tabs, wrong indentation, etc. The point of these comments is to make the code more readable for everyone.

javihernandez · 2015-07-08T15:27:29Z

@Diegohp,

also, I would love to have most of the new added functions into a separate .java file (ie: utilities.java). I would like to keep the GpiiActivity.java file as cleaner (and readable) as possible.

javihernandez · 2015-07-17T11:32:15Z

platform/app/src/net/gpii/app/GpiiActivity.java

missing dep

javihernandez · 2015-07-17T11:38:11Z

Hi @Diegohp,

it's not building here, I'm getting the following results when trying to build it:

-compile:
    [javac] Compiling 82 source files to /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/bin/classes
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:28: error: package org.apache.commons.compress.archivers.tar does not exist
    [javac] import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
    [javac]                                                 ^
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:29: error: package org.apache.commons.compress.archivers.tar does not exist
    [javac] import org.apache.commons.compress.archivers.tar.TarArchiveInputStream;
    [javac]                                                 ^
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:30: error: package org.apache.commons.compress.compressors.gzip does not exist
    [javac] import org.apache.commons.compress.compressors.gzip.GzipCompressorInputStream;
    [javac]                                                    ^
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:181: error: cannot find symbol
    [javac]                 action = intent.getAction();
    [javac]                 ^
    [javac]   symbol: variable action
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:182: error: cannot find symbol
    [javac]                 if (DownloadManager.ACTION_DOWNLOAD_COMPLETE.equals(action)) {
    [javac]                                                                     ^
    [javac]   symbol: variable action
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:196: error: cannot find symbol
    [javac]                 } else if (action.equals(ACTION_GPII_UNZIP_COMPLETE)) {
    [javac]                            ^
    [javac]   symbol: variable action
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:425: error: cannot find symbol
    [javac]             TarArchiveInputStream tarIn = null;
    [javac]             ^
    [javac]   symbol:   class TarArchiveInputStream
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:427: error: cannot find symbol
    [javac]             tarIn = new TarArchiveInputStream(new GzipCompressorInputStream(
    [javac]                         ^
    [javac]   symbol:   class TarArchiveInputStream
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:427: error: cannot find symbol
    [javac]             tarIn = new TarArchiveInputStream(new GzipCompressorInputStream(
    [javac]                                                   ^
    [javac]   symbol:   class GzipCompressorInputStream
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:430: error: cannot find symbol
    [javac]             TarArchiveEntry tarEntry = tarIn.getNextTarEntry();
    [javac]             ^
    [javac]   symbol:   class TarArchiveEntry
    [javac]   location: class GpiiActivity
    [javac] Note: /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 10 errors

BUILD FAILED

Here I see 2 problems:

Missing dependencies: already commented on the relevant import lines
The action variable is never defined

Can you please fix these problems?

javihernandez · 2015-07-17T11:42:54Z

In relation to the missing dependencies,

anode is already including an utility for dealing with tar files, isn't it enough for our purposes? Is it really needed to include a new one?

Diegohp · 2015-07-17T11:58:13Z

Added dependencies for Tar and Gzip

javihernandez · 2015-07-17T12:27:54Z

Added dependencies for Tar and Gzip

I meant including the libraries, not importing them in the source code again

javihernandez · 2015-08-17T10:27:00Z

platform/prebuild.sh

Why aren't we using the apache's official download URL of this library?

javihernandez · 2015-08-17T10:36:49Z

@Diegohp,

please, whenever you make a change and you want me to keep reviewing it, just let me know, we don't receive notifications when you add commits to the pull request.

javihernandez · 2015-08-17T10:41:05Z

Even by applying your last commit, it's not building:

-compile:
    [javac] Compiling 82 source files to /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/bin/classes
    [javac] error: error reading /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/libs/commons-compress-1.5.jar; error in opening zip file
    [javac] 1 error

BUILD FAILED
/home/jhernandez/Downloads/Android/adt-bundle-linux-x86_64-20140321/sdk/tools/ant/build.xml:720: The following error occurred while executing this line:
/home/jhernandez/Downloads/Android/adt-bundle-linux-x86_64-20140321/sdk/tools/ant/build.xml:734: Compile failed; see the compiler error output for details.

Total time: 2 seconds

…ght jar library from maven repository

Diegohp · 2015-09-03T17:26:53Z

Hi @javihernandez, we have upload some changes to prebuild.sh file and fixed some errors in GpiiActivity.java and main.xml, in order to build Gpii Android app. We tested it, and everything should be work

…rings, GPII User Listerners for NFC and QR, and GPII Architecture on the same project

javihernandez · 2015-10-28T16:25:56Z

Hey @Diegohp,

thanks for pushing on this! Right now I'm getting this build error

-pre-compile:

-compile:
    [javac] Compiling 82 source files to /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/bin/classes
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:142: error: cannot find symbol
    [javac]         ctx = this;
    [javac]         ^
    [javac]   symbol:   variable ctx
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:189: error: cannot find symbol
    [javac]                             uriUserListeners = myxml.getText();
    [javac]                             ^
    [javac]   symbol:   variable uriUserListeners
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:204: error: cannot find symbol
    [javac]                             gpiiUserListenersAPK = myxml.getText();
    [javac]                             ^
    [javac]   symbol:   variable gpiiUserListenersAPK
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:273: error: cannot find symbol
    [javac]                                 userListenersNotInstalledDialog(gpiiUserListenersAPK);
    [javac]                                                                 ^
    [javac]   symbol: variable gpiiUserListenersAPK
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:792: error: cannot find symbol
    [javac]         Request request = new Request(Uri.parse(uriUserListeners));
    [javac]                                                 ^
    [javac]   symbol:   variable uriUserListeners
    [javac]   location: class GpiiActivity
    [javac] /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java:794: error: cannot find symbol
    [javac]             + gpiiUserListenersAPK)));
    [javac]               ^
    [javac]   symbol:   variable gpiiUserListenersAPK
    [javac]   location: class GpiiActivity
    [javac] Note: /home/jhernandez/drafts/GPII-Android-Installer/android/platform/app/src/net/gpii/app/GpiiActivity.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 6 errors

BUILD FAILED

any ideas?

javihernandez · 2015-10-29T11:40:28Z

Also, I'm randomly experiencing this right before the installation ends:

D/AndroidRuntime( 5691): Shutting down VM
W/dalvikvm( 5691): threadid=1: thread exiting with uncaught exception (group=0x40d1b2a0)
E/AndroidRuntime( 5691): FATAL EXCEPTION: main
E/AndroidRuntime( 5691): java.lang.RuntimeException: Error receiving broadcast Intent { act=net.gpii.app.ACTION_GPII_UNZIP_COMPLETE flg=0x10 } in net.gpii.app.GpiiActivity$1@418ff2a0
E/AndroidRuntime( 5691):    at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:765)
E/AndroidRuntime( 5691):    at android.os.Handler.handleCallback(Handler.java:615)
E/AndroidRuntime( 5691):    at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime( 5691):    at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime( 5691):    at android.app.ActivityThread.main(ActivityThread.java:4856)
E/AndroidRuntime( 5691):    at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 5691):    at java.lang.reflect.Method.invoke(Method.java:511)
E/AndroidRuntime( 5691):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1007)
E/AndroidRuntime( 5691):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:774)
E/AndroidRuntime( 5691):    at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime( 5691): Caused by: java.lang.IllegalArgumentException: View not attached to window manager
E/AndroidRuntime( 5691):    at android.view.WindowManagerImpl.findViewLocked(WindowManagerImpl.java:653)
E/AndroidRuntime( 5691):    at android.view.WindowManagerImpl.removeView(WindowManagerImpl.java:349)
E/AndroidRuntime( 5691):    at android.view.WindowManagerImpl$CompatModeWrapper.removeView(WindowManagerImpl.java:160)
E/AndroidRuntime( 5691):    at net.gpii.app.GpiiActivity$1.onReceive(GpiiActivity.java:290)
E/AndroidRuntime( 5691):    at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:755)
E/AndroidRuntime( 5691):    ... 9 more

Have you experienced the same issue before?

javihernandez · 2015-10-29T11:47:49Z

platform/app/src/net/gpii/app/GpiiActivity.java

As far as I can see, the resource is called "gpii-android" (without the .tar.gz extension), and I'm not seeing any renaming-related process within this last commit. Am I overlooking it?

Diegohp · 2015-10-30T18:10:38Z

Hi Javi! We just added some changes to GpiiActivity in order to fix the issues you have found. Please, test it as soon as possible.

Merge remote-tracking branch 'Diegohp/GPII-installer_FVE.git' into demoKit * Diegohp/GPII-installer_FVE.git: Changes added to GpiiActivity to fix some bugs Added changes to install GPII Android Application with declarative Strings, GPII User Listerners for NFC and QR, and GPII Architecture on the same project Some errors fixed. Added modification into prebuild.sh to download right jar library from maven repository prebuild.sh file modified to import common compress library Adding dependencies for tar an gzip New indentation added to whole class with four spaces Added 4 spaces instead tabulation on GpiiActivity.java. Added header Changes applied to GpiiActivity.java and AndroidManifest.xml for upgrading GpiiActivity Android application in order to autodeploy it

javihernandez · 2015-11-03T17:03:20Z

@Diegohp,

thanks for your good job on this!
Since we don't see this for master, I've merged it into a new branch called demoKit, so we can get back to it in the future.

Changes applied to GpiiActivity.java and AndroidManifest.xml for upgr…

cec293e

…ading GpiiActivity Android application in order to autodeploy it

javihernandez reviewed Jun 30, 2015
View reviewed changes

platform/app/src/net/gpii/app/GpiiActivity.java Outdated

Copy link

Member

javihernandez Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every message needs to be in english

javihernandez reviewed Jun 30, 2015
View reviewed changes

platform/app/src/net/gpii/app/GpiiActivity.java Outdated

Copy link

Member

javihernandez Jun 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Cloud4all/GPII

Branch updated with last changes for the GPII installer with last GPI…

7fd02b1

…I Android version

javihernandez self-assigned this Jul 3, 2015

javihernandez added the Needs Work label Jul 3, 2015

javihernandez reviewed Jul 7, 2015
View reviewed changes

platform/app/src/net/gpii/app/GpiiActivity.java

Copy link

Member

javihernandez Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect the headers

Added 4 spaces instead tabulation on GpiiActivity.java. Added header

02c1f08

javihernandez reviewed Jul 8, 2015
View reviewed changes

platform/app/src/net/gpii/app/GpiiActivity.java Outdated

Copy link

Member

javihernandez Jul 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty whitespaces

New indentation added to whole class with four spaces

5df96c2

javihernandez reviewed Jul 17, 2015
View reviewed changes

platform/app/src/net/gpii/app/GpiiActivity.java

Copy link

Member

javihernandez Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing dep

Adding dependencies for tar an gzip

419e520

prebuild.sh file modified to import common compress library

08e4c90

javihernandez reviewed Aug 17, 2015
View reviewed changes

platform/prebuild.sh Outdated

Copy link

Member

javihernandez Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we using the apache's official download URL of this library?

Some errors fixed. Added modification into prebuild.sh to download ri…

0416093

…ght jar library from maven repository

Added changes to install GPII Android Application with declarative St…

d7a883f

…rings, GPII User Listerners for NFC and QR, and GPII Architecture on the same project

javihernandez reviewed Oct 29, 2015
View reviewed changes

Changes added to GpiiActivity to fix some bugs

ea287c4

Conversation

Diegohp commented Jun 26, 2015

Uh oh!

javihernandez Jun 30, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez commented Jun 30, 2015

Uh oh!

javihernandez Jun 30, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez Jul 7, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez Jul 8, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez commented Jul 8, 2015

Uh oh!

javihernandez commented Jul 8, 2015

Uh oh!

javihernandez Jul 17, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez commented Jul 17, 2015

Uh oh!

javihernandez commented Jul 17, 2015

Uh oh!

Diegohp commented Jul 17, 2015

Uh oh!

javihernandez commented Jul 17, 2015

Uh oh!

javihernandez Aug 17, 2015

Choose a reason for hiding this comment

Uh oh!

javihernandez commented Aug 17, 2015

Uh oh!

javihernandez commented Aug 17, 2015

Uh oh!

Diegohp commented Sep 3, 2015

Uh oh!

javihernandez commented Oct 28, 2015

Uh oh!

javihernandez commented Oct 29, 2015

Uh oh!

javihernandez Oct 29, 2015

Choose a reason for hiding this comment

Uh oh!

Diegohp commented Oct 30, 2015

Uh oh!

javihernandez commented Nov 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants